325 points by judahmeek 3 days ago | 459 comments | View on ycombinator
alkonaut 2 days ago |
littlecranky67 2 days ago |
With human coding, the lazyness of the developer and the urge to keep things simple and deliver faster often leads to simple solutions (with a time/effort/return tradeoff). With AI, I get overblown MRs that work, but oftentimes could be simpler (with said tradeoffs). So my work has become more difficult and time consuming, and the codebases grows faster. And I don't think my team members learn or grow at the same rate as they did before.
Now, I have no strong feelings against AI - it is just a tool afterall. And I have no experience what the long-term effects of this will be (just as anybody else).
AlwaysRock 2 days ago |
lz400 2 days ago |
jacobgorm 2 days ago |
Buttons840 2 days ago |
The way you would naturally review an existing codebase is not the same way it grows through individual commits. Therefore, focusing reviews on individual commits is less efficient.
We need better tooling and a better approach.
Overdrivr 2 days ago |
gzell 3 days ago |
karmicthreat 2 days ago |
Instead, we're front-loading the human part in the design phase. Humans review a high-level design; AI implements the design based on the design decisions humans made. That way we can avoid having someone dig through a 10K-line PR for a major change.
Not sure if this is going to work out. We will probably still have some cadence of human-driven and AI-assisted DRY and de-sprawl of code. But AI does a really good job of implementation in our particular area (robotics).
teravor 2 days ago |
I wound up with a bunch of LLM written tools that I don't even bother to try and understand much less review, they either function as desired or I set an LLM to make them function (or just rewrite them) and then forget about them. make sure to keep a prompt in each tool's directory and update it an needed.
sadly this isn't always possible, some systems require complexity at some level. in those cases the tools from above become functions and objects and more care needs to be taken into orchestrating them to limit the necessity of review. data oriented design approaches and functional programming help here.
sadilek 2 days ago |
IMO, 2 doesn't need code review by a human anymore. Agents can review each other. I add a broad code audit for DRY, YAGNI, KISS every once in a while and let agents fix the findings.
And for 1, code review was always too low-level. I have agents produce artifacts that are convenient for me to review. Often narrated demo videos, sometimes HTML pages with graphs and tables.
With this, code review is not a bottle neck, and I find myself working not as an engineer anymore but as an engineering director.
jeppester 2 days ago |
The big speed up comes from not having to understand the code - e.g. not doing thorough human review.
Personally I find that super hard, because whenever I review AI code I find many things that could have been a lot simpler or more readable.
But whether I like it or not, I think we are heading more and more towards just trusting the machine.
snizovtsev 2 days ago |
u1hcw9nx 3 days ago |
forty_shenaniga 2 days ago |
dangoodmanUT 2 days ago |
I guess it depends a lot on how a company manages their SDLC/bureaucracy
FinnLobsien 2 days ago |
So presumably this is based on existing codebases where an engineer exists who knows the codebase extremely well and can provide good reviews.
I wonder how this will work for codebases started post-coding agents, where nobody has ever written every line from scratch. How does review even work if nobody knows the failures modes they have tested and discarded and the 219 edge cases they've debugged?
sotander about 20 hours ago |
bengold14 2 days ago |
1. It was good for collaboration. Sharing how you are changing the codebase pushes everyone to row in the same direction, and provides a sense of team ownership.
2. It was good as a push for engineers to take pride in their work. Knowing someone is watching gives you subconsciously an extra reason to not cut corners. And when you spend effort not cutting corners you expect that in your teammates, which is a (potentially) virtuous circle.
3. It was good for catching mistakes. When code was expensive this was important.
Everyone thinks of code review as primarily relevant for 3, and since code is no longer expensive they think it is unimportant. But 3 isn't dead, its importance has just shifted from code to architecture. It is still an expensive mistake to screw up architecture and have other engineers build upon that flaw. Re-architecting with live users, data and/or hardware is not as simple as fixing a code bug, and it deserves attention to catch mistakes. Collaboration & pride are also still important.
This is the reason that instead of stopping review, we need to change what and how we review.
(disclosure I work in this space and run https://www.archme.io which is working to solve the above, also responded to a lower down comment with this but decided to move it to top level)
simonw 2 days ago |
Key methodology:
> We leverage a novel proprietary dataset from Jellyfish (JF), an analytics platform that companies use to understand the activity of their software engineering teams. Our data allows us to measure details of the software production process, covering 445 million work events of 720,542 workers across 655 firms, from January 2021 to August 2026. JF combines data from industry-standard software engineering tools, and we use four of these tools: (1) code version control systems, such as GitHub, which track engineers’ code; (2) issue management systems, such as Jira, which measure engineers’ progress on and completion of software tasks and projects; (3) scheduling tools, such as Google Calendar, which capture meeting activity and time allocation; and (4) generative AI usage at the firm and worker level, for GitHub Copilot, Cursor, and Claude Code.
Copernicron 1 day ago |
sivanmz 2 days ago |
mlikelihood 1 day ago |
We've built auto-reviewers (I'm sure you can do it on any grok bot / dot / solutions etc.) and auto-review resolvers -- always-on agents running in sandbox and review and RESOLVE comments (with new commits) on any author's github profile. You can tune the prompts for nit-picking, pushing back, etc.
Then you can do regular audit to see how many false positive and negatives are there in all the PRs merged.
Over time, we've noticed less and less P0 bugs are even caught, and the for those P1 and P2 issues, auto-resolving is perfectly fine/low to no risk at all if it's just another "polishment" like edge case handling that's not so common.
Then the problem now shifts to architecture design, task decomposition, etc.
dgggh 2 days ago |
oorestisime 2 days ago |
devrians2001 1 day ago |
gpulogy45 1 day ago |
swframe2 1 day ago |
There are actions spread across many data sources: email, chat, bugs, documents, meeting notes, tests results against dev/staging/production environments, code reviews, etc. There are things you need approval for and data you need to provide to get approved. AI has increased the amount of actions and the expectation that you can do them quickly.
Have you found or created tools/skills that help coordinate the actions you need to take?
dominotw 2 days ago |
novia 2 days ago |
JonoW 2 days ago |
wkoszek 1 day ago |
skeledrew 2 days ago |
osigurdson 2 days ago |
Digitalisierung 1 day ago |
m3kw9 2 days ago |
catketch 2 days ago |
8trackbattlecat 2 days ago |
It is such a nightmare to try and keep maintainable code as it takes so much longer to demonstrate problems than it does to generate slop, meanwhile management doesnt care if its buggy as hell.
And then when a problem arises the dev who made the code with ai is useless.
figers 2 days ago |
bob1029 2 days ago |
I've observed that code review tends to concentrate to one person. It's always the slowest asshole of a person too for some reason. The amount of meltdowns I've seen these people go through over the most insignificant bullshit was off the charts well before AI showed up. I used to be one of these people.
I think code review like this has always been a bad idea. Code ownership is what you want. Put developers on the hook with git blame perpetually. Why should a developer be excused from responsibility the moment a PR merges? This is the core of the dysfunction.
The only reason code review worked at all is because we were going slow enough that the obstructionists could hide in the shadows. Now they're out in broad daylight in the middle of a desert. It's up to leadership to decide what kind of company they want at this point.
grahar64 2 days ago |
ilitirit 2 days ago |
FWIW, I've started tested Sol 6.2 today. Hopefully it's better...
simianwords 2 days ago |
undefined 2 days ago |
nico 2 days ago |
That’s solved, for anyone who wants to automate it (of course it’s not perfect, but it’s pretty reliable for mainstream workloads, eg. building a web app in a well known language with a well known framework - well known = well represented in the training set of the coding agents)
It’s about human attention. That’s the bottle neck. We are only able to review some many things in a certain amount of time (code, results, goals, UI, UX, etc). So even we don’t review the code at all, someone is going to have to review/approve the results
undefined 2 days ago |
brylie 2 days ago |
wewewedxfgdf 2 days ago |
fmajid 2 days ago |
ozgrakkurt 2 days ago |
gadders 2 days ago |
sinsterizme 2 days ago |
I think the bottleneck in the long term will be feature prioritization and specification, and testing. My role has already shifted a lot more into more CI checks to keep LLMs on guardrails
shehjar 2 days ago |
alt-machine-ref 2 days ago |
An example what they tech you in a b-school.
jackgavigan 2 days ago |
shearerp 2 days ago |
Given that, it seems ridiculous to me that so many people are shoveling raw AI slop to their code review team the moment it meets whatever absolute minimum standard is needed to submit for review (if that).
The laziness. The chutzpah. My goodness. Either have some respect for the craft, or find another job.
If all you do is feed the Jira ticket to the AI, you should be replaced. The reviewer could do that themselves, and get to a superior result faster.
judahmeek 3 days ago |
Tryvrsakjo10 2 days ago |
igrekel 1 day ago |
undefined 2 days ago |
nout 2 days ago |
randomCloud 1 day ago |
bitwize 2 days ago |
You can never truly understand a piece of code. This is why bugs and defects slip through all the time. So you may as well let AI do the review and understanding for you, since it will be much more thorough as Project Glasswing and Black October have demonstrated. That feeling of control you so desperately crave—surrender it. The technical portion of software development will be handled 99% by machines now. Your human judgement is on the business side. Become an entrepreneur, if you don't see a path to management track where you work.
stego-tech 2 days ago |
This is not necessarily a bad thing in a vacuum.
Where the problem comes in are incentive structures - especially in Western companies - to produce as fast as possible. So we write agents to do our code reviews, or we just accept the code blindly and let tests in staging or dev sort out the issues. Velocity does increase like leadership demands, but at the expense of oversight and knowledge of the underlying systems and code.
It’s frustrating to be sure, but so long as the short-term incentives promote velocity over all else (security, stability, and sustainability), then this is just going to continue getting worse. Short of a giant (metaphorical) bomb going off - like classifying all AI code as open source sans IP protections, as an example - this won’t change.
hibbelig 2 days ago |
thom 2 days ago |
ttctciyf 2 days ago |
stakhanov 2 days ago |
"Hey, Joe! It just took you all week to do something that could have been written by Claude in 15 minutes and reviewed by my most valuable engineer in 5 minutes. Why did you take so long?" "...well, I am not yet one of your most valuable engineers, so it took me a lot longer to review all of what Claude did and to first develop an understanding of all the context in the codebase." "Sounds to me like a lame excuse."
It's a lesson they won't learn until after a few go-rounds of the personnel turnover carousel.
Eridanus2 2 days ago |
Woodi 2 days ago |
As for code: ask for better code so reviews will be more straightforward ?
Like, for example: modularization, some structure, maybe libraries for code reuse ? ;) Ooo, and functions, do not forget about functions !
Sorry, didn't started yet with llms because lack of affordable local 256 Gb of gfx memory...
QuantumNoodle 2 days ago |
Now there is a trend toward approvals without human review for "low risk changes." Which completely conflicts the "you own the output."
dmitrygr 2 days ago |
They needed Harvard researchers for that? Anyone in the industry could have told them that. Hell, my cat knows it (cause i complain to her about it incessantly)
undefined 2 days ago |
root_axis 2 days ago |
apt-apt-apt-apt 2 days ago |
stevelacey 1 day ago |
estebarb 2 days ago |
This does not spark joy.
medellin 2 days ago |
bill10 2 days ago |
diego_moita 2 days ago |
I suspect that the old assembly programmers had the same hope and feeling about the first higher level compilers for Ada, Pascal and C. And guess what? There are very few assembly programmers these days.
AI code is here to stay and will only grow. Deal with it. More than in any other area it is quite silly to be a Luddite in IT.
tyrtop 2 days ago |
TexanFeller 2 days ago |
ion_trapper 2 days ago |
hauntingseaweed 2 days ago |
kasnaka 2 days ago |
dvrp 2 days ago |
RomanPushkin 1 day ago |
crnkofe 2 days ago |
jsrozner 2 days ago |
EspressoGPT 2 days ago |
undefined 2 days ago |
thisismyopinion 2 days ago |
swiftcoder 2 days ago |
The interesting question, is how do we solve that? Have agents reached the point that we can assign a codebase quality czar agent swarm to handle review, and actually have good results?
12ahsGk 2 days ago |
Maybe academics should stop using propaganda language even if they are instructed by Harvard's endowment fund to use mild language.
fzxu22 1 day ago |
water42 2 days ago |
stackzero 2 days ago |
avereveard 2 days ago |
undefined 1 day ago |
preetnation 2 days ago |
milleramp 2 days ago |
darkmatriarch 2 days ago |
makoto12 2 days ago |
inshard 2 days ago |
fractorial 2 days ago |
pmarreck 2 days ago |
undefined 2 days ago |
wewewedxfgdf 2 days ago |
snailcoder 2 days ago |
nehasinghfounde about 17 hours ago |
ntheogr 1 day ago |
firethief6 2 days ago |
arbor-group 2 days ago |
Shexfer 2 days ago |
ginthian 1 day ago |
serhii-a8 2 days ago |
furytrader 2 days ago |
ankur_misra 2 days ago |
taioladipupo 2 days ago |
haukebri 2 days ago |
zahurul_islam 2 days ago |
longhei_pcyw 2 days ago |
roninsediment 2 days ago |
undefined 2 days ago |
brodydung 2 days ago |
gettoolslab 2 days ago |
jchip303 2 days ago |
proc0 2 days ago |
It's baffling the industry is choosing to move in the direction of more reviews which implies more things can fail.
TheBlight 2 days ago |
I'm very good at telling agents what to do. That's not a problem. I understand a code base I worked 20 years in like no one else. The problem creeps in slowly: the less I know about this code base, the worse I'll be at directing agents. They'll do ok on their own, and they can certainly help me understand code too in a way my colleagues never could. But still, I'm slowly becoming less and less familiar with my own code base. In a few years, it would be foreign to me. And I would be describing changes in terms of high level features instead of architectural changes, refactorings and so on, that I do now. And I don't yet trust the LLMs to do a good job with that. So right now there's sort of a honeymoon period when the human understanding of code is good, and the LLMs are finally good enough to write and modify code. But I wonder what will happen after that.